[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Trace Past URL From Peg Revision - rev 5

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2004-04-02 21:07:22 CEST

On Fri, 2004-04-02 at 13:07, Shlomi Fish wrote:
> Here is a new revision:
> http://shlomif.il.eu.org/svn-patches/peg-revision-patch-rev8.patch
> Changes since last time:
> 1. More tests added.
> 2. Made the tests' interface more robust.
> 3. The standalone command line client for the peg function can now open
> http:// URLs. (albeit still segfaults afterwards because the handler in the
> vtable is not implemented.)

You still haven't written a log message. This is the single biggest
obstacle preventing people from paying attention to the patch. You said
you "didn't have time" to write one yesterday, yet you've spent time
since then adding more code instead (?)

Don't underestimate the importance of the log message, or the importance
of responding to feedback from other developers. Participating in an
open-source project is more than just throwing patches over a wall. :-)

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 2 21:08:31 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.