Re: [PATCH] Prevent the modification of the URL [was 1.0.1 veto for r8959]

Greg Hudson wrote:

> > Perhaps it would be better if the switch editor
> > modified the directory URL at close_directory time ("I have made the
> > necessary changes to this dir to change its location" vs. "I plan to
> > make the changes to this dir to change its location").

I don't agree... the whole design of the update-editor is based on the
idea that open_root() and open_dir() immediately write out the new
(revnum, URL) into the entries file with the 'incomplete' flag. This is
the reason checkouts/updates are restartable.

So the real issue here is: who's in charge of validating the URL before
the editor-driver actually begins to drive?

I think the spirit of makl's patch is just fine: the reporter code can
definitely do some sanity checking before beginning the editor drive.
The "old" txn-based reporter code used to do that, so makl's patch fixes
a regression of some sort.

But in addition to makl's patch, I think we should also try to identify
earlier opportunities to validate the URL as well.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 22 21:34:05 2004