Re: [PATCH] Prevent the modification of the URL [was 1.0.1 veto for r8959]

Greg Hudson wrote:

> I'm not convinced that drive() is doing anything wrong by calling
> open_root before generating an error; it hasn't told the editor to
> make any changes yet.

If open_root (and open_directory later) doesn't change the URL of the
directory, all file entries and maybe other things.

> Perhaps it would be better if the switch editor
> modified the directory URL at close_directory time ("I have made the
> necessary changes to this dir to change its location" vs. "I plan to
> make the changes to this dir to change its location").

Maybe. But this is a bigger task than just preventing the modification
of the URL.

> (A potentially larger issue: I'm not sure if an aborted switch
> operation can leave directories in a consistent state.

As far as I tested it the directory is in a consistent state. Sure some
entries are still at the source branch, but you can solve the problem
and retry the switch.

> I suppose it might be enough to set the start-empty flag on the directory
> between the open-dir and close-dir steps.)

This will affect all operations that use update under the hood.

> and could have explained a few things better.
My English is not very well and thus I have some problems to find good
descriptions. I will try to improve this.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 22 18:19:22 2004