[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r9060 mailer.py broke sending author

From: Greg Stein <gstein_at_lyra.org>
Date: 2004-03-19 19:13:54 CET

On Thu, Mar 18, 2004 at 10:24:09PM -0800, Blair Zajac wrote:
>...
> I'm using the description that's been in the mailer.conf.example
> file for the behavoir:
>
> # The default From: and To: addresses for commit messages. If the
> # from_addr is not specified or it is specified but there is no text
> # after the `=', then the revision's author is used as the from
> # address. If the revision author is not specified, such as when a
> # commit is done without requiring authentication and authorization,
> # then the string 'no_author' is used. You can specify a default
> # from_addr here and if you want to have a particular for_repos group
> # use the author as the from address, you can use "from_addr =".
>
> I read this last sentence to mean I can have this:
>
> from_addr =
>
> in a repository section. Although, rereading it now, it could
> also mean
>
> from_addr = some_address@domain
>
> So the comment could be made clearer.

Clearer? Blah. Somebody totally changed the behavior in the code.

/me sighs

> "C. Michael Pilato" wrote:
> > I do remember seeing an annoyance with our config reader
> > that makes it impossible to tell the different between a missing
> > option and an option with no value (which mean entirely different
> > things to me, semantically).

Unrelated. The code simply doesn't do what the comments says it should be
doing. And I don't think the above is true. The code uses getattr, rather
than testing values.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 19 19:11:57 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.