Re: r9060 mailer.py broke sending author

"C. Michael Pilato" wrote:
>
> Blair Zajac <blair@orcaware.com> writes:
>
> > Can you send the output of 'grep -v ^# mailer.conf | uniq' from
> > svn.collab.net along? I'll take a look and see what differences
> > there are.
>
> No. It's seekr1t.

Wow, no Google matches on that word. You just won a million dollars!

> But the main difference is that every repos has its own section, and
> every section has from_addr set to something real. I'll see if I can
> fix the problem for you.

Thanks.

> To be clear, what should the correct behavior be? My guess would be
> that if from_addr is empty, it should default to the [default]
> from_addr.

I'm using the description that's been in the mailer.conf.example
file for the behavoir:

# The default From: and To: addresses for commit messages. If the
# from_addr is not specified or it is specified but there is no text
# after the `=', then the revision's author is used as the from
# address. If the revision author is not specified, such as when a
# commit is done without requiring authentication and authorization,
# then the string 'no_author' is used. You can specify a default
# from_addr here and if you want to have a particular for_repos group
# use the author as the from address, you can use "from_addr =".

I read this last sentence to mean I can have this:

from_addr =

in a repository section. Although, rereading it now, it could
also mean

from_addr = some_address@domain

So the comment could be made clearer.

> I do remember seeing an annoyance with our config reader
> that makes it impossible to tell the different between a missing
> option and an option with no value (which mean entirely different
> things to me, semantically).

Agreed.

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org