[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: More urls treated as paths...

From: Ben Reser <ben_at_reser.org>
Date: 2004-03-19 04:30:15 CET

On Thu, Mar 18, 2004 at 08:15:17PM -0700, D.J. Heap wrote:
> There's at least two more places where urls can be passed to
> svn_cmdline_path_local_style_from_utf8 in the commandline client -- in
> the remote handling of propget and proplist. This causes forward
> slashes in the url to be converted to backslashes on Windows.
>
> Should we just fix these individually, or would it be appropriate to
> make svn_cmdline_path_local_style_from_utf8 smarter about it (and
> probably rename it to something else)? It still would not recognize
> relative url's...but I'm not sure how many places we have those besides
> the log callback?

I think we should fix them individually. Making the function smarter as
you point out wouldn't solve the whole problem. While, individual fixes
can reasonably solve the entire problem.

Renaming the function isn't a good option. It's in the public API. I
tend to think the name is fine. It's just being misapplied to URLs.

Looks like it is used in the info command, propedit, propset, propget,
propdel, status and proplist. I haven't looked to see if they are
correct or not.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 19 04:30:28 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.