[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Proposed New Feature (SVNROOT)

From: Nuutti Kotivuori <naked_at_iki.fi>
Date: 2004-03-17 04:49:19 CET

Brian Denny wrote:
> On Tue, Mar 16, 2004 at 11:51:38PM +0200, Nuutti Kotivuori wrote:
>>
>> And unless the extent of the functionality was already discussed
>> (like I assume it wasn't from the patch), I strongly would urge you
>> to discuss the actual semantics of SVNROOT on the list first, get a
>> consensus on what would be sane behaviour, and hopefully start
>> coding after you've got a green light that this indeed is a wanted
>> change.
>
> I want to make a remark about this.
>
> I have observed a number of times on this list that a user comes to
> the list with a feature request, and they get a response something
> like "I don't really think this feature is worth the effort, but
> you're welcome to submit a patch".
>
> Which, if said before the actual semantics have been worked-out on
> list, may encourage the sort of "code-first, ask questions later"
> pattern that you (Nuutti) are trying above to discourage.
>
> Furthermore, I fear a kind of subtext-misunderstanding. "You're
> welcome to submit a patch" sounds like encouragement, but I feel
> like sometimes people say this when what they really mean is "This
> is *so* low on my priority list that I don't even want to discuss it
> right now. If you come back with a patch, maybe I'll consider
> spending my time on it." -- Which is a perfectly valid attitude,
> but I just hope the potential patch submitter is hearing the right
> message.
>
> I'm not necessarily saying that either of the above comments applies
> to this particular case.

I believe there's a bit of oranges and apples here - and definitely
the "submit a patch" is a confusing comment and your woes are rightly
placed here. I believe HACKING might require some clarification.

The difference comes in the nature of the discussion.

When some issue is discussed in the mailing list in general terms, the
answers that contain the message "This is *so* low on my priority list
that I don't even want to discuss it right now." are sometimes given
with the comment "submit a patch".

The proper response to that is "I am willing to code this feature by
the guidelines in HACKING and iterate the patch into Subversion, and
this is my proposed design, please give feedback on it."

And I can guarantee people will discuss it then - if nothing else,
then putting into words their reasons why it shouldn't be done - and
possibly voting on it if it comes to that.

So the actual message is not ever "if you come back with a patch,
maybe I'll consider spending my time on it" - but it is "show your
willingness to actually work this problem through its iterations, and
I'll spend time commenting it."

So, on the actual matter - SVNROOT patch - I think the first step
would be to post a detailed proposal on how to handle the interface
and get that approved.

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 17 04:49:35 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.