Re: Proposed New Feature (SVNROOT)

On Tue, Mar 16, 2004 at 09:22:22AM -0500, Greg Hudson wrote:
> I didn't review the patch carefully, but this jumped out at me:
>
> + char buf[strlen(svnroot)+strlen(local_dir)+1];
> + sprintf(buf, "%s/%s", svnroot, local_dir);
>
> You've made use of a gcc extension here; in regular old C, arrays must
> have constant length. Use apr_psprintf() instead.

Actually that's in C99 now. But we're using C89 as our target so we
shouldn't use such things as you pointed out.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org