[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: The new svn_wc_adm_*_depth functions.

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-03-11 00:46:43 CET

Jon Foster <jon@jon-foster.co.uk> writes:

>> Index: subversion/libsvn_client/status.c
>> ===================================================================
>> --- subversion/libsvn_client/status.c (revision 8957)
>> +++ subversion/libsvn_client/status.c (working copy)
>> @@ -155,8 +155,8 @@
>> /* Using pool cleanup to close it. This needs to be recursive so that
>> auth data can be stored. */
>> if (strlen (anchor) != strlen (path))
>> - SVN_ERR (svn_wc_adm_open (&anchor_access, NULL, anchor,
>> FALSE, - TRUE, pool));
>> + SVN_ERR (svn_wc_adm_open_depth (&anchor_access, NULL,
>> anchor, FALSE, + -1, pool));
>
> Does this *really* need to be recursive? The comment says so; I don't
> know enough about the auth mechanism to be sure.

The comment is out of date, it refers to an era when auth data was
stored in the working copy. There may be other reasons why the
recursive lock is required.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 11 00:46:57 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.