I can run this through the tests and commit it this weekend if no one
beats me to it, there are no objections, and Philip still approves it,
of course.
Thanks!
DJ
Jon Foster wrote:
> Philip Martin wrote:
>
>> I like this patch, I'll approve it for the trunk subject to the
>> minor cosmetic changes below:
>
> [snip]
>
> Patch with your requested changes is attached. It's against trunk r8891.
>
> Any chance of getting this into 1.0.1?
>
> There are other two things I want to do, but these shouldn't stop
> you from applying this patch:
>
> 1) DJ spotted a subtle bug in my original patch (fixed in this patch).
> I will write a test-case for this so that in future a "make check"
> would spot it.
> 2) I'd like to reduce further the number of locks that are taken.
> This patch still errs on the side of locking too much, which gives
> correct output but is not as fast as possible. It locks much less
> than before, though. This looks like it will require careful
> thought and testing - which is one reason to write the test-cases
> first. (This is the FIXME in the patch).
>
> Kind regards,
>
> Jon Foster
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 9 00:15:00 2004