"D.J. Heap" <dj@shadyvale.net> writes:
I like this patch, I'll approve it for the trunk subject to the
minor cosmetic changes below:
> When getting the non-recursive status of a child of the working copy
> directory, the anchor selected is the parent of the target
> directory. This means the depth passed on down needs to be 2 rather
> than 1 so that it can find the status of the target's children that
> are themselves directories.
This explanation, or an abbreviated version of it, ...
> + /* Need to lock the tree. A non-recursive status requires the
> + immediate subdirectories to be locked. A recursive status
> + requires us to lock the whole tree. */
... should replace this comment.
> + SVN_ERR (svn_wc_adm_probe_open_depth (&adm_access, NULL, anchor,
> + FALSE, (descend ? -1 : 2), pool));
>
Jon Foster <jon@jon-foster.co.uk> writes:
> Index: subversion/include/svn_wc.h
> ===================================================================
> --- subversion/include/svn_wc.h (revision 8867)
> +++ subversion/include/svn_wc.h (working copy)
> +/**
> + * Same as svn_wc_adm_open_depth(). @a depth is set to -1 if @a tree_lock is
"Similar to" rather than "Same as"
> + * @c TRUE, else 0.
> + *
> + * Provided for backward compatibility with the Subversion 1.0.0 API.
> + */
> svn_error_t *svn_wc_adm_open (svn_wc_adm_access_t **adm_access,
> svn_wc_adm_access_t *associated,
> const char *path,
> +/**
> + * Same as svn_wc_adm_probe_open_depth(). @a depth is set to -1 if
ditto
> + * @a tree_lock is @c TRUE, else 0.
> + *
> + * Provided for backward compatibility with the Subversion 1.0.0 API.
> + */
> svn_error_t *svn_wc_adm_probe_open (svn_wc_adm_access_t **adm_access,
> svn_wc_adm_access_t *associated,
> const char *path,
> +/**
> + * Same as svn_wc_adm_probe_try_depth(). @a depth is set to -1 if
ditto
> + * @a tree_lock is @c TRUE, else 0.
> + *
> + * Provided for backward compatibility with the Subversion 1.0.0 API.
> + */
> svn_error_t *svn_wc_adm_probe_try (svn_wc_adm_access_t **adm_access,
> svn_wc_adm_access_t *associated,
> const char *path,
> Index: subversion/libsvn_wc/lock.c
> ===================================================================
> --- subversion/libsvn_wc/lock.c (revision 8867)
> +++ subversion/libsvn_wc/lock.c (working copy)
> +/* This kludge is to preserve API compatibility with 1.0 */
I don't reconise this as a kludge, just "To preserve ..." will do.
> svn_error_t *
> svn_wc_adm_open (svn_wc_adm_access_t **adm_access,
> svn_wc_adm_access_t *associated,
> @@ -504,7 +509,19 @@
> svn_boolean_t tree_lock,
> apr_pool_t *pool)
> {
> +/* This kludge is to preserve API compatibility with 1.0 */
ditto
> svn_error_t *
> svn_wc_adm_probe_open (svn_wc_adm_access_t **adm_access,
> svn_wc_adm_access_t *associated,
> +/* This kludge is to preserve API compatibility with 1.0 */
ditto
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 2 22:01:35 2004