Re: svn commit: r8839 - trunk/subversion/libsvn_client

Philip Martin <philip@codematters.co.uk> writes:

> > + if (keywords_val)
> > + SVN_ERR (svn_subst_build_keywords (&keywords, keywords_val->data,
> > + "-1", "", 0, "", pool));
>
> The "-1" looks very odd, how about APR_STRINGIFY(SVN_INVALID_REVNUM)?

Ooh! I was looking for something like that. Thanks.

> The documentation for svn_subst_build_keywords states that NULL
> indicates information not present, perhaps those "" should be NULL?
> Looking at the implementation I see that a NULL revision isn't
> supported, should the documentation or the implementation change?

Implementation, I'd say.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 27 00:38:49 2004