cmpilato@tigris.org writes:
> Author: cmpilato
> Date: Wed Feb 25 16:57:41 2004
> New Revision: 8839
>
> Modified:
> trunk/subversion/libsvn_client/add.c
> trunk/subversion/libsvn_client/client.h
> trunk/subversion/libsvn_client/commit.c
> Log:
> Finish Issue #1756 - import doesn't handle svn:eol-style or svn:keywords.
> Modified: trunk/subversion/libsvn_client/commit.c
> ==============================================================================
> --- trunk/subversion/libsvn_client/commit.c (original)
> +++ trunk/subversion/libsvn_client/commit.c Wed Feb 25 16:57:41 2004
> + /* If we have EOL styles or keywords to de-translate, do it. Any
> + EOL style gets translated to "\n", the repository-normal format.
> + Keywords get unexpanded. */
> + if (eol_style_val || keywords_val)
> + {
> + svn_subst_keywords_t keywords = {0};
> + const char *temp_dir;
> + svn_stream_t *tmp_stream;
> + apr_file_t *tmp_f;
> +
> + /* Get a readable stream of the file's contents. */
> + SVN_ERR (svn_io_file_open (&f, path, APR_READ, APR_OS_DEFAULT, pool));
> + contents = svn_stream_from_aprfile (f, pool);
> +
> + if (keywords_val)
> + SVN_ERR (svn_subst_build_keywords (&keywords, keywords_val->data,
> + "-1", "", 0, "", pool));
The "-1" looks very odd, how about APR_STRINGIFY(SVN_INVALID_REVNUM)?
The documentation for svn_subst_build_keywords states that NULL
indicates information not present, perhaps those "" should be NULL?
Looking at the implementation I see that a NULL revision isn't
supported, should the documentation or the implementation change?
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 26 23:59:06 2004