Re: PATCH: Check for cancellation before doing something, not afterwards

Julian Foad <julianfoad@btopenworld.com> writes:
> The sort of use case I am thinking of is typing "svn update" or
> whatever, then while it goes through the phase of connecting to the
> repository, hitting Ctrl-C. In this sort of situation it is
> annoying if it then proceeds to update one file before obeying the
> Ctrl-C.
>
> Any support for this patch?

Yes. It looks like a good idea to me. All the cases you changed are
in loops, where you're just moving the check from the end of the loop
body to the beginning. (If there were a case where the new check at
the beginning were *still* preceded by some real work, then I'd say
leave the original loop-end check in as well, but I think there aren't
any such cases, right?)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 19 17:51:02 2004