Re: Messages from hooks

Ben Collins-Sussman <sussman@collab.net> writes:

> Calm down, guys. :-) This is issue 443, a well-known, long-time
> shortcoming in mod_dav_svn. Read that issue for background.

I'm not so sure. Issue 443 is the post-commit hook, while the OP is
complaining about the pre-revprop-change hook. The pre-revprop-change
hook *should* return an error over ra_dav, but it doesn't appear to be
working. Using trunk@HEAD I'm getting a core dump in mod_dav_svn :-(

$ cat repo/hooks/pre-revprop-change
#!/bin/sh
echo bug >$2
exit 1

$ svn ps --revprop -r1 svn:log bar http://localhost:8888/obj/repo
../svn/subversion/libsvn_ra_dav/fetch.c:1172: (apr_err=175002)
svn: DAV request failed; it's possible that the repository's pre-revprop-change hook either failed or is non-existent
../svn/subversion/libsvn_ra_dav/props.c:1072: (apr_err=175008)
svn: At least one property change failed; repository is unchanged

$ cat /usr/local/apache2/logs/error_log

[Thu Feb 19 16:45:38 2004] [notice] Apache/2.0.48 (Unix) DAV/2 SVN/0.37.0+ configured -- resuming normal operations
[Thu Feb 19 16:45:45 2004] [error] [client 127.0.0.1] 'pre-revprop-change' hook failed with error output:
bug
  [500, #165001]
[Thu Feb 19 16:45:45 2004] [error] [client 127.0.0.1] (84)Invalid or incomplete multibyte or wide character: 'pre-revprop-change' hook failed with error output:
bug
oa [500, #165001]
!õ #?ö ï [500, #165001]4] [error] [client 127.0.0.1]  
[Thu Feb 19 16:45:46 2004] [notice] child pid 1413 exit signal Segmentation fault (11)
[Thu Feb 19 16:45:46 2004] [notice] child pid 1412 exit signal Segmentation fault (11)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org