[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r8139 never merged...

From: <kfogel_at_collab.net>
Date: 2004-01-24 05:19:51 CET

Ben Reser <ben@reser.org> writes:
> r8139 never got voted on or merged in 1.0-stabilization. This means
> username prompt providers are still broken in 1.0. This patch has been
> on trunk since Jan 3rd. So I'm not sure how we missed it. But I
> noticed it when testing the 1.0-stabilization branch tonight.

It was missed because it wasn't in the STATUS file.

> I'm adding it to the STATUS file. Hopefully enough people can vote on
> this to get it into 0.37. *sigh*

I'll take a look at it right now. Maybe enough other people are still
around to get it in.

Looking at the bugs, they're not truly terrible, so it's not a huge
crisis if this doesn't make it in.

-Karl

> For convience the log follows:
>
> r8139 | bliss | 2004-01-03 02:45:32 -0800 (Sat, 03 Jan 2004) | 52 lines
> Changed paths:
> M /trunk/subversion/libsvn_client/simple_providers.c
> M /trunk/subversion/libsvn_client/username_providers.c
>
> Fix two bugs when the prompt providers are not installed (e.g. when
> the cmdline option --non-interactive is used):
>
> 1. No username was used by ra_local.
>
> 2. Authentication failed if --password was used without --username.
>
> Move the code to get the username from the OS from the username and
> simple prompt providers to the regular providers. Improve code
> readability and error checking.
>
> The old code saved the values that was read from disk in the provider
> baton to avoid saving unchanged data, but now that we have the
> may_save parameter in the creds struct we use that method in all
> simple and username providers instead.
>
> Thanks to Ben Reser <ben@reser.org> for finding the problem and
> providing the initial patch!
>
> * subversion/libsvn_client/username_providers.c
>
> (provider_baton_t): Remove redundant member.
>
> (get_creds): Remove.
>
> (save_creds): Remove.
>
> (username_first_creds): Move the code from get_creds here. Move code
> to get the username from the OS in prompt_for_username_creds here.
>
> (username_save_creds): Move the code from save_creds here.
>
> (prompt_for_username_creds): Move code to get the username
> from the OS to username_first_creds.
>
> * subversion/libsvn_client/simple_providers.c
>
> (provider_baton_t): Remove redundant members.
>
> (get_os_username): New function to get the OS username.
>
> (get_creds): Remove.
>
> (save_creds): Remove.
>
> (simple_first_creds): Move the code from get_creds here. Get the
> default username from the OS.
>
> (simple_save_creds): Move the code from save_creds here.
>
> (prompt_for_simple_creds): Use get_os_username.
>
>
> --
> Ben Reser <ben@reser.org>
> http://ben.reser.org
>
> "Conscience is the inner voice which warns us somebody may be looking."
> - H.L. Mencken
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 24 06:17:13 2004

This is an archived mail posted to the Subversion Dev mailing list.