[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r8463 - in trunk/subversion: include mod_dav_svn

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2004-01-23 20:52:06 CET

"Erik Huelsmann" <e.huelsmann@gmx.net> writes:

> Just quickly scanning and it looks good, but I think you leaked an error
> (twice - with the same construct).

[...]
> > + /* Flush the contents of the brigade (returning an error only if we
> > + don't already have one). */
> > + if (((apr_err = ap_fflush(output, lrb.bb))) && (! derr))
> > + derr = dav_svn_convert_err(svn_error_create(apr_err, 0, NULL),
> > + HTTP_INTERNAL_SERVER_ERROR,
> > + "Error flushing brigade.");
> > + return derr;
> > }
>
> You're not clearing serr here, or above, but neither does
> dav_svn_convert_err.

Yeah, actually, I was planning to make dav_svn_convert_err() destroy
the Subversion error.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 23 20:52:58 2004

This is an archived mail posted to the Subversion Dev mailing list.