Re: [Issue 1705] apr_off_t is of an ambiguous size

On Fri, 2004-01-23 at 14:46, Sander Striker wrote:
[Regarding svn_diff_contains_conflicts and friends:]
> > What does being read-only have to do with needing a pool? You need a
> > pool if any of the work you're doing requires memory allocation, whether
> > or not that memory is interesting to the caller.

> None of that work requires memory allocation. It's walking a list
> and returns true/false depending on whether there are conflicts/diffs.

That seems like it depends on the internal representation of a diff.
Right now it's just a matter of walking a list and checking flags, but
that's not the only possible representation. I think it's much cheaper
to take a pool which we don't currently need than it is to find the door
shut on performing memory allocations if we need to do so in the future.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 23 20:52:07 2004