[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svncpp crash in ssl_server_trust_file_save_credentials

From: Tobias Ringstrom <tobias_at_ringstrom.mine.nu>
Date: 2004-01-21 12:18:51 CET

Barry Scott wrote:
> See issue #153 it has the full text of the patch, including the fix.

Thanks!

>> a little hard to read the patch. I'm very interested in how you handle
>> the may_save boolean in the C++ API. The idea is that the may_save
>> boolean that is passed to the prompt function is to be used to enable
>> or disable (i.e. gray out) a "remember name and password" checkbox in
>> a prompt dialog. If the user checks that box, the may_save in the
>> creds struct shall be set to TRUE. It's handled in the same way for
>> most (if not all) providers. Just send me an email if I can help.
>
> The may_save should default the check box to save/don't save as the users
> preference. Why would I force the user to edit an icky text file before
> the GUI allows them to save credientials?

No, that is not how it works. If the may_save argument to the prompt
function is FALSE, it means that it is impossible to save. Even if you
set may_save in the creds struct to TRUE, it will not be saved. If the
application wants to remember a default setting for the user, it must do
so in an application specific way (probably utilizing the prompt baton).
That has nothing to do with the svn libs.

/Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 21 12:19:33 2004

This is an archived mail posted to the Subversion Dev mailing list.