Re: svncpp crash in ssl_server_trust_file_save_credentials

At 20-01-2004 22:25, Tobias Ringström wrote:
>Barry Scott wrote:
>>Thanks for taking the trouble to look at the svncpp code.
>
>It's was a pleasure. Getting rapidsvn/svncpp up to date is a very
>worthwhile goal.

Or in my case svncpp and pysvn, I'm working on the python svn GUI Workbench
rather then rapidsvn.

>>Reordering the providers to put the file ones first fixes the crash.
>>I'll update the svncpp patch for 0.36.0 support to include this fix.
>
>Cool. I couldn't get your patch to apply properly (probably due to MUA
>damage) so it was

See issue #153 it has the full text of the patch, including the fix.

>a little hard to read the patch. I'm very interested in how you handle the
>may_save boolean in the C++ API. The idea is that the may_save boolean
>that is passed to the prompt function is to be used to enable or disable
>(i.e. gray out) a "remember name and password" checkbox in a prompt
>dialog. If the user checks that box, the may_save in the creds struct
>shall be set to TRUE. It's handled in the same way for most (if not all)
>providers. Just send me an email if I can help.

The may_save should default the check box to save/don't save as the users
preference. Why would I force the user to edit an icky text file before
the GUI allows them to save credientials?

The alternative design to the may_save flag is an API to query the svn
preferences. Is there such an API? I have not looked.

         Barry

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 21 11:50:12 2004