Re: svn commit: r8343 - trunk/subversion/libsvn_ra_svn

[Appologies if this appears twice, but I think I lost the first one.]

kfogel@collab.net writes:

> Greg Hudson <ghudson@MIT.EDU> writes:
>> > * subversion/libsvn_ra_svn/cram.c (compute_digest): Use an unsigned
>> > char array for the secret. Patch from Philip Martin.
>>
>> The bitwise operations performed on secret are all xors, so there should
>> be no semantic problem with them being (possibly) signed char. So, it's
>> mainly an issue of warnings with pickier compilers. Do people think
>> that's important enough for a 1.0 pullup?
>
> Personally, I'd rather not. We're already accumulating a lot of
> little proposed changes late in the game. This one doesn't seem that
> compelling, given that all we're preventing is a compile warning on
> some platforms.

It's a bit more than that, the report that led to this patch involved
using the xlc compiler on AIX, and it was a compiler *error*. xlc
also has the "volatile sig_atomic_t" problem for which I don't have a
ready solution, other than suggesting that those that encounter it
delete volatile from the code. I suspect neither problem affects gcc
on AIX.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org