[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r8343 - trunk/subversion/libsvn_ra_svn

From: <kfogel_at_collab.net>
Date: 2004-01-16 21:22:11 CET

Greg Hudson <ghudson@MIT.EDU> writes:
> > * subversion/libsvn_ra_svn/cram.c (compute_digest): Use an unsigned
> > char array for the secret. Patch from Philip Martin.
>
> The bitwise operations performed on secret are all xors, so there should
> be no semantic problem with them being (possibly) signed char. So, it's
> mainly an issue of warnings with pickier compilers. Do people think
> that's important enough for a 1.0 pullup?

Personally, I'd rather not. We're already accumulating a lot of
little proposed changes late in the game. This one doesn't seem that
compelling, given that all we're preventing is a compile warning on
some platforms.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 16 22:18:14 2004

This is an archived mail posted to the Subversion Dev mailing list.