Re: svn commit: r8343 - trunk/subversion/libsvn_ra_svn

Greg Hudson wrote:

>On Fri, 2004-01-16 at 13:20, ghudson@tigris.org wrote:
>
>
>>* subversion/libsvn_ra_svn/cram.c (compute_digest): Use an unsigned
>> char array for the secret. Patch from Philip Martin.
>>
>>
>
>The bitwise operations performed on secret are all xors, so there should
>be no semantic problem with them being (possibly) signed char.
>
But there can be a difference on one's complement or sign+magnitude
machines. They're about as rare as the ones where all-bits-zero is not
the null pointer, but if we're being pedaintic, the standard does say
that "unsigned char" is the correct representation for raw memory, not
plain char.

> So, it's
>mainly an issue of warnings with pickier compilers. Do people think
>that's important enough for a 1.0 pullup?
>
>
No.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org