Re: svn commit: r8341 - trunk/subversion/libsvn_subr

Jani Averbach wrote:

>I think it is better to use construction:
>
>#ifdef WIN32
>#define WIN32_RETRY_LOOP(err, expr) \
> do { \
> ... \
> while(0)
>
>
That's fine, but, uh,

>#else
>#define WIN32_RETRY_LOOP(err, expr) do {} while(0)
>#endif
>
>
Why would you want to define an empty loop? Just defining the macro to
an empty string will do the same job and be more concise.

An C statement can be empty. The following

    void foo(void)
    {
      ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    }

is a valid C program.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org