[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: apr_off_t is of an ambiguous size.

From: Kean Johnston <jkj_at_sco.com>
Date: 2004-01-12 22:00:58 CET

> It seems much more logical to simply always use a 64-bit offset and to
> #ifdef the bounds checking we'd need on the machines that have an APR
> built with a 32-bit off_t.
Thats a good approach too. However, I would suggest you use real code,
not an ifdef, to do the switching. It may well result in a constant
condition which the optimizer will eliminate, but in general its better
to get to the real truth of the matter as the compiler sees it (which
can, as you know, be subtly different to what the pre-processor sees).
So if you make the SVN type always be 64 bits, at the point you need to
possibly downscale, do something like:

  if (sizeof(aprtype) < sizeof(svntype)) {
    whatever();
  }

> Users build subversion too you know. I don't think it's realstic to
> expect them to just know the details of large file support. Fixing the
Thats fair. I think its rarer than a developer doing it, but I can see
it happening. Of course, only a developer is likely to be in need of an
SCM, especially at its bleeding edge version, but your point is valid :)

> Fair enough. Sorry for venting at you about that. Wrote the reply
No harm done. I've had to develop a skin so thick it would make a rhino
blush with envy over the last few months :)

Kean

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 12 22:02:57 2004

This is an archived mail posted to the Subversion Dev mailing list.