[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: apr_off_t is of an ambiguous size.

From: Ben Reser <ben_at_reser.org>
Date: 2004-01-12 21:44:37 CET

On Mon, Jan 12, 2004 at 12:22:12PM -0800, Kean Johnston wrote:
> I would expect that querying Perl should tell you that.

Sure and we ask perl for the compile flags we need. One of which is the
OFFSET_BITS stuff. However, that doesn't mean that APR was built that
way and it would be wrong to just turn on the flag and ignore the issue.
So simply fixing the build system to turn it on when perl has it turned
on would be wrong. We'd still have to do bound checking for what we'd
pass into APR.

It seems much more logical to simply always use a 64-bit offset and to
#ifdef the bounds checking we'd need on the machines that have an APR
built with a 32-bit off_t.

> And you seem to be confusing users and developers. Users dont need to
> be aware of the issue, developers do.

No I'm not. This is a user visible issue. I install a fresh copy of
Mandrake. I decide I want the latest subversion that hasn't been
packaged. So I download and build it. Except now this nifty perl
script that I've been using that I didn't write segfaults.

Users build subversion too you know. I don't think it's realstic to
expect them to just know the details of large file support. Fixing the
build system would require us to do some of the pain of bounds checking
anyway. Might as well get the benefits of a fixed size in our interface
while we're at it.

> Thats was completely uncalled for, and I think you know it. Please
> redirect your anger at my employer to the appropriate channels, not at
> any random person who happens to post. Thank you.

Fair enough. Sorry for venting at you about that. Wrote the reply
shortly after getting up and should have put more thought into what I
was saying.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 12 21:45:32 2004

This is an archived mail posted to the Subversion Dev mailing list.