On Thu, 2004-01-08 at 18:59, Justin Erenkrantz wrote:
> --On Thursday, January 8, 2004 4:32 PM -0600 kfogel@collab.net wrote:
>
> > Should we abandon the three +1's system for bindings changes on the
> > 1.0 branch?
>
> I'd rather not as I'm not convinced that the current system can't work.
> And, that by not having review, we're encouraging 'islands' of
> participation that are intimately tied to only one or two people (see our
> packaging problems).
I'm particularly concerned about one of the javahl bindings changes. I
don't think those bindings have received a lot of review from committers
in the past (I'm not saying I've identified bugs or mistakes in the
code; I'm just relying on memory and that it doesn't look as normalized
as heavily-reviewed code tends to), and r8020 in particular was too
tough for me to review.
The perl bindings may be in the same category, but I haven't looked as
hard at those changes yet, simply because they weren't as high up in the
status file when I was making that pass.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 9 06:59:22 2004