[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r8085 and r8104

From: David Summers <david_at_summersoft.fay.ar.us>
Date: 2004-01-08 01:28:45 CET

kfogel@collab.net wrote:

>I've just added a "concept" +1 to this item in STATUS:
>
> * r8055, r8085, r8104, r8105
> RPM Documentation build patch and added svnserve.conf and snvserve man
> pages. Also require correct apr/apr-util, and apache RPM versions.
> Justification: Packaging fixes and additions.
> Votes:
> +1 (concept): gstein, kfogel
>
>The middle two revisions there are really the same patch, applied to
>both rpms/redhat-7.x/ and rpms/redhat-8+/.
>

Yes, it was taking me long enough to do both sets that I went ahead and
commited one before the other, normally I would have commited them both
at the same time. Someone was pestering me to get it working so I went
ahead and commited one.

>David, I can change my vote to a real +1 if you can confirm to me that
>"%{__perl}" lines in the patch work exactly as intended. That's the
>one part I didn't feel competent to review, but I'm happy to go out on
>a limb for you if you've tested this :-).
>

Yes, the build completes and creates the documentation. Before it
didn't. Of course this is a "band-aid" for fixing the real cause. Even
better would be to do that but I'm not competent to understand the book
build process and why it didn't work without that. So I took the patch
from Ben Reser (thanks Ben!) :-) I'd be happy if the book build
process just worked out-of-the-box. If someone can show me where I'm
doing something wrong I'll be happy to fix it.

> Also, you might want to
>vote on this item yourself!
>

Oh. I thought only full-access committers could vote. I'll go back and
read the voting instructions.

>One thing:
>
>In those two revisions, part of the patch looks like this:
>
> +# Start patch by Ben Reser <ben@reser.org> to get documentation to build.
> +%{__perl} -pi -e [...]
> +%{__perl} -pi -e [...]
> +# End patch by Ben Reser <ben@reser.org> to get documentation to build. For the future: when applying a patch, you can take out the markers
>left by the contributor, and (if appropriate) replace them with a more
>timeless comment, for example:
>
> +# Build documentation.
> +%{__perl} -pi -e [...]
> +%{__perl} -pi -e [...]
>
>If we always left comments like this in the code
>
> ### JRANDOM: here's the start of my mods
> [...]
> ### JRANDOM: here's the end of my mods
>
>... well, let's just say we wouldn't need version control :-).
>
>
OK. I just wanted to attribute the patch to Ben and not myself. :-) I
guess I could do that in the %changelog section.

    - David Summers

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 8 01:29:24 2004

This is an archived mail posted to the Subversion Dev mailing list.