Re: svn_auth.h API change

--On Sunday, December 28, 2003 11:32 AM -0600 kfogel@collab.net wrote:

> And Justin Erenkrantz, why did you vote +1 on this change (for 1.0)
> even though it had doc bugs? :-)

How are you testing for doc bugs? I don't have the tools installed to test
for this. And, tools/examples isn't even in our build system. If you mean
for this to be part of our validation, then we should add it to our build.

> These reviews should be serious & thorough. Even Tobias hadn't voted
> +1 on it yet (I don't know if that was an oversight, or if he had been
> planning to review his own change again before voting.)
>
> That's all. I'm sure I'll make a review mistake at some point too;
> and I hope I'll be held to account when I do! (By Justin, preferably.)

I care more about correctness bugs. And, I looked at *every* line of the
patch, confirmed that it was implemented in a sane manner without any problems
that were evident to me. (I helped with the design of the auth system, so
yes, I know how it should work.)

If Tobias didn't fix the docstrings, because I casted a +1 to it, I would fix
it myself. But, he already did so in r8101. I honestly don't know what more
you'd expect from volunteers. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 29 07:09:31 2003