[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_auth.h API change

From: <kfogel_at_collab.net>
Date: 2003-12-28 18:32:41 CET

Ben Collins-Sussman <sussman@collab.net> writes:
> Tobias, you changed the auth API in r8013, but didn't update all the
> docstrings.
> I was trying to compile tools/examples/minimal_client.c today, and
> discovered that the prompt_func prototypes had changed, but their
> docstrings in svn_auth.h made no mention of the new 'may_save'
> parameter. I had to read the r8013 log message to understand it.
> Can you look over r8013, and make sure the new parameter is documented
> everywhere it's declared?

And Justin Erenkrantz, why did you vote +1 on this change (for 1.0)
even though it had doc bugs? :-)

These reviews should be serious & thorough. Even Tobias hadn't voted
+1 on it yet (I don't know if that was an oversight, or if he had been
planning to review his own change again before voting.)

That's all. I'm sure I'll make a review mistake at some point too;
and I hope I'll be held to account when I do! (By Justin, preferably.)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 28 19:25:17 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.