Re: PATCH: Stop defining identifiers in APR's name space

kfogel@collab.net wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>>Ah, yes. Acually if we're not absolutely sure they will go into
>>APR, it's wrong to have "APR" in their names, so that should just be
>>"svn__foo" or, in svn_sorts.h, "svn_sort__foo".
>
> No, in general it's okay, just don't *begin* with "apr".

I didn't mean that having "_apr_" within the name is an abuse of namespaces, I meant it misleadingly implies that the function has something to do with APR when in fact it may never become a part of APR. No big deal either way, though.

>>Unfortunately I will be pretty much off-line from tomorrow until
>>about 6th January, so I probably won't have time to do this now.
>>Anyone please feel free to continue this.
>
> No problem. Can you attach your latest patch to the issue?

Done.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 20 02:04:55 2003