Re: Leaking errors

Ben Collins-Sussman <sussman@collab.net> writes:

> On Thu, 2003-12-18 at 20:36, Julian Foad wrote:
>
>> How should failure of svn_fs_check_path be handled here?
>
> I don't think there's anything wrong with wrapping the serr in a
> dav_svn_convert_err(). You've got the right idea.

Does dav_svn_convert_err do the right thing? It accepts an
svn_error_t* and returns a dav_error*, but it doesn't appear to clear
the svn_error_t pool. So it looks like every dav_svn_convert_err
leaks. Fixing it could be ugly; simply adding an svn_error_clear
won't work since the dav error itself is allocated in the svn_error_t
pool. I think dav_svn_convert_err may need to grow a pool parameter.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org