Re: PATCH: Stop defining identifiers in APR's name space

Greg Hudson <ghudson@MIT.EDU> writes:
> > * subversion/libsvn_fs/bdb/dbt.c
> > (apr_free_cleanup): Rename this static function to "free_cleanup".
> > (svn_fs__track_dbt): Adjust accordingly.
>
> > * subversion/libsvn_subr/io.c
> > (apr_dir_is_empty): Rename this static function to "dir_is_empty".
> > (svn_io_dir_empty): Adjust accordingly.
>
> I'd say punt this stuff for now. We shouldn't be using apr_ symbols
> internally in our code, but it would take an awful lot of churn to fix
> that. (Think "apr_err".) The goal here is to fix the API with a
> minimum of pain.

I think Greg's right about these (in my original response, should have
said the same as what he says above).

API first, internal stuff later.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 19 19:37:19 2003