Re: PATCH: Stop defining identifiers in APR's name space

On Fri, 2003-12-19 at 11:17, Julian Foad wrote:
> I believe this was mentioned as something that is needed before 1.0.

Thanks for having a go at this.

> (apr_hash_sorted_keys): Rename to "svn_sort_hash".

That's probably fine. I'm not convinced that apr wants to get into this
area, and if it does, it won't be the end of the world to support
svn_sort_hash as an alias for that function.

> (apr_array_prepend): Delete, as it was unused.

Also fine.

> (apr_atoui64): Rename this macro to "svn_atoui64".

Not so fine. I don't want to be committed to exporting an svn_atoui64
symbol. Call it svn__atoui64 and mark it with a comment as not for use
by code outside of our tree.

> * subversion/libsvn_fs/bdb/dbt.c
> (apr_free_cleanup): Rename this static function to "free_cleanup".
> (svn_fs__track_dbt): Adjust accordingly.

> * subversion/libsvn_subr/io.c
> (apr_dir_is_empty): Rename this static function to "dir_is_empty".
> (svn_io_dir_empty): Adjust accordingly.

I'd say punt this stuff for now. We shouldn't be using apr_ symbols
internally in our code, but it would take an awful lot of churn to fix
that. (Think "apr_err".) The goal here is to fix the API with a
minimum of pain.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 19 18:01:40 2003