[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fix Win32 file handle leak in translate-test.exe?

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-12-18 20:08:44 CET

On Thu, 2003-12-18 at 05:58, Erik Huelsmann wrote:
> > No, I spoke correctly.
> >
> > Though perhaps unclearly: by "it's a bug either way," I mean if you are
> > running an unbounded loop without pool cleanups, you have a bug. If you
> > notice this bug because a file handle doesn't get cleaned up, then
> > that's your fault, not the fault of the function which left a file
> > handle to be closed by pool cleanup.
> Does this mean you don't like what Brane did to the function with his patch?
> There is / was a bug in the function itself: the function did not close a
> file when trying to remove it. If this causes a handle leak on Windows that is
> a problem which should be addressed. Branes patch does that.

I misunderstood the problem. I think brane's fix is fine.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 18 20:09:30 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.