Re: Fix Win32 file handle leak in translate-test.exe?

Greg Hudson wrote:

>Can you better explain how translate-test was failing? Were we running
>the translate command in a loop without cleaning a pool?
>
>I continue to believe that it's appropriate to rely on pool cleanups for
>files as well as memory. It may take a smaller loop without pool
>cleanup to notice a resource problem with open files, but it's a bug
>either way.
>
>
The problem is that the bug was _within_ the function itself, regardless
of pool cleanup -- in the case of an error, it attempted to remove the
temporary file even though it had not been closed first. That has
nothing to do with the concept of pool cleanup for closing files.

My patch fixes this bug by using pool cleanup to make sure the files get
closed.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org