Re: Fix Win32 file handle leak in translate-test.exe?

Erik Huelsmann wrote:

>>>In the deltification-in-Apache case, it is both the only way and the
>>>documented way to do cleanup after sending a response to a client. I
>>>don't like it there either, but it was the best available option.
>>>That's not the case with file handles.
>>>
>>>
>>Exactly.
>>
>>
>I don't get it: you depend on pool cleanup for closing the files yourself.
>This contradicts what you have said until now. The only difference is that you
>introduced a new pool to guarantee the files have been cleaned up at a
>certain moment.
>
>
And that is the crucial difference. I never said pool cleanup shouldn't
be used to close file handles -- after all, apr_file_close is nothing
but a wrapper for pool cleanup. But we must control when files are closed.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org