[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fix Win32 file handle leak in translate-test.exe?

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2003-12-18 10:55:54 CET

> >In the deltification-in-Apache case, it is both the only way and the
> >documented way to do cleanup after sending a response to a client. I
> >don't like it there either, but it was the best available option.
> >That's not the case with file handles.
> Exactly.
I don't get it: you depend on pool cleanup for closing the files yourself.
This contradicts what you have said until now. The only difference is that you
introduced a new pool to guarantee the files have been cleaned up at a
certain moment.

> And I'm totally against "fixing" this bug by changing the test. My patch
> fixes the cause, and I vote we include it in 0.35.0.

I didn't mean we have to change the tests. Never intended to declare the
tests wrong even.
Anyway; I'll stop about it now.

The fix is one of many possible but since it works I'm +1 on the patch and
including it in 0.35.0.



+++ GMX - die erste Adresse fr Mail, Message, More +++
Neu: Preissenkung fr MMS und FreeMMS! http://www.gmx.net
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 18 10:56:31 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.