[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: API issues we might want to solve for 1.0

From: Ben Reser <ben_at_reser.org>
Date: 2003-12-15 23:29:20 CET

On Sun, Dec 14, 2003 at 03:36:53PM -0800, Ben Reser wrote:
> I'll wait to see if there's a consensus on the naming issue and regen
> the patch with these fixes, unless someone applies it with the fixes
> themselves.

Looks like svn_client_create_context it is...

The attached patch now uses that name, fixes the style issues that
ghudson noticed.

It now returns svn_error_t so that the function is no longer dependent
upon the internal implementation not being able to fail. Clients will
already be checking the return so such a change would not require an API
or ABI visible change.

Future proof the ABI by providing an allocator/initializer function for
the client context.
* subversion/libsvn_client/ctx.c
* subversion/include/svn_client.h
  (svn_client_create_context): New function
* subversion/clients/cmdline/main.c
* subversion/tools/examples/minimal_client.c
  Use svn_client_create_context().

Ben Reser <ben@reser.org>
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Dec 15 23:30:31 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.