Re: API issues we might want to solve for 1.0

On Sun, Dec 14, 2003 at 06:40:22PM -0500, Greg Hudson wrote:
> On Sun, 2003-12-14 at 18:36, Ben Reser wrote:
> > > > - svn_client_ctx_t ctx = { 0 };
> > > > + svn_client_ctx_t *ctx = NULL;
> > >
> > > Don't initialize the pointer to an invalid value; all that serves to do
> > > is defeat the compiler's logic for determining whether the pointer is
> > > used before it's initialized to a valid value.
> >
> > Then someone should fix this 3 lines below my change too:
> > const svn_opt_subcommand_desc_t *subcommand = NULL;
>
> No, NULL is a valid value for subcommand. It is not a valid value for
> ctx.

Okay I see now. For some reason I missed that subcommand wasn't being
set before the first time it could be used.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org