[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn blame and filenames with non-ascii chars

From: John Szakmeister <john_at_szakmeister.net>
Date: 2003-12-13 16:19:45 CET

On Saturday 13 December 2003 07:40, SteveKing wrote:
> [snip]
> Steps to reproduce:
>
> - add a file with a special name to wc (e.g. ".txt")
> and commit
> - change the file and commit (not sure if that's really needed to
> reproduce)
> - try 'svn blame <filepath_to_that_file>'
> svn: Error string not specified yet
> svn: Missing changed-path information for revision 3 of '%C3%A4%C3%B6%C3%B
> C%C3%84%C3%96%C3%9C.txt'

Thanks Stefan! I was able to reproduce this and track down the problem. It
turns out that the log message baton had the path stored in URI format, while
the changed path keys where UTF-8 encoded.

Here is the patch and the log message. Since we're getting strict on commits,
and I've never been a part of this process before (at least not for a project
this big), I'll wait for approval before committing this change.

-John

Log:
Fix the case where paths containing non-ascii characters would cause the blame
command to fail.

* subversion/libsvn_client/blame.c
  (svn_client_blame): Convert the path stored in the message baton from a URI
  encoding to UTF-8.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sat Dec 13 16:15:13 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.