Re: [BUG] The client can't use a different directory than .svn

D.J. Heap wrote:

> The key function is v_extend_with_adm_name in libsvn_wc/adm_files.c, I
> believe. However, this seems to be a heavily used function and
> putting a check for the current admin dir name (potentially two
> checks) every time it is called seemed like it could be expensive
> unless some caching was done or something (perhaps I'm missing
> something obvious, of course). I haven't had time to pursue it
> further than this brief analyses, though.

There's more to the change than that. Just search for all places in the
code that use the #define, and you'll see it's a non-trivial problem.

> Just changing the #define on Windows works, but breaks old working
> copies (if no other work is done to upgrade them) and prevents them
> from being used on other OS', although the utility of that is
> questionable it sounds like.
>
> Also, for what it's worth, I would prefer '_svn' to just 'svn' if it
> comes to renaming the admin dir. Mostly just because it sorts
> nicer...no really strong feelings, though.

Sorting isn't really an issue if the directoryis hidden. the probability
of shooting yourself in the foot is, though. It's much more probable
that someone will want to put a file or directory called "svn" under
version control than "_svn" (or "__svn__", ...).

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org