On Tuesday 02 December 2003 22:20, Julian Foad wrote:
> John Szakmeister wrote:
> > On Tuesday 02 December 2003 17:45, Julian Foad wrote:
> >>I am also playing with the following patch:
> >>
> >>Index: subversion/libsvn_wc/lock.c
> >>===================================================================
> >>--- subversion/libsvn_wc/lock.c (revision 7899)
> >>+++ subversion/libsvn_wc/lock.c (working copy)
> >>@@ -738,6 +738,9 @@
> >> assert (! adm_access->set_owner || apr_hash_count
> >> (adm_access->set) == 0); }
> >>
> >>+ /* Invalidate the baton so that attempts to use it will be caught. */
> >>+ memset (adm_access, 0, sizeof(*adm_access));
> >>+
> >> return SVN_NO_ERROR;
> >> }
> >>
> >>
> >>It catches the error that is the subject of this message, but makes lots
> >> of other tests fail too. I'm still investigating whether it is finding
> >> real bugs or is a wrong thing to do.
> >
> > Interesting that this caused other errors. I'm curious to know what you
> > find! :-)
>
> It does catch a few other instances of using an adm_access baton after it
> was closed. The attached patch fixes all but one tricky case, marked with
> "###". Do you fancy trying to see how to deal with that tricky case?
Nice work!
Sure, why not? :-) I started looking at the problem, and actually tried
several different solutions with no success. I was expecting different
errors than what I got. Some of the tests were bailing out, but didn't leave
a trace of what went wrong when I moved the run_log command to be after the
recurse portion. There was no error output, but some tests bailed out right
in the middle of the commit.
If I can't get this over the next couple of days, I'll push it back out to the
list for someone else to try.
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 3 11:20:55 2003