[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7857 - in trunk/subversion: libsvn_client libsvn_ra_svn libsvn_subr mod_dav_svn svnserve

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-12-01 17:00:42 CET

Greg Stein <gstein@lyra.org> writes:

>> +++ trunk/subversion/libsvn_client/copy.c Wed Nov 26 15:45:54 2003
>> @@ -718,7 +718,7 @@
>> cleanup:
>> /* Abort the commit if it is still in progress. */
>> if (commit_in_progress)
>> - editor->abort_edit (edit_baton, pool); /* ignore return value */
>> + svn_error_clear (editor->abort_edit (edit_baton, pool));
> You lost the comment here. I think it should stick around. The code is
> specifically ignoring an error result. The question that arises is: was
> that intended, or accidental?

I don't think "ignore return value" adds anything--svn_error_clear
documents that adequately. It may be appropriate to add a comment
explaining why any error should be ignored, but this need for a
rationale applies equally to the original code.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 1 17:01:33 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.