[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7857 - in trunk/subversion: libsvn_client libsvn_ra_svn libsvn_subr mod_dav_svn svnserve

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-12-01 17:41:55 CET

On Mon, 2003-12-01 at 05:43, Greg Stein wrote:
> > - editor->abort_edit (edit_baton, pool); /* ignore return value */
> > + svn_error_clear (editor->abort_edit (edit_baton, pool));
> You lost the comment here. I think it should stick around. The code is
> specifically ignoring an error result. The question that arises is: was
> that intended, or accidental?

I agree with Phillip; the svn_error_clear() makes it quite clear that
ignoring the result is intentional. A comment is only necessary if it's
not obvious why the error is being ignored, and I think in this case
it's pretty obvious (we already have an error to return).

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 1 17:48:18 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.