Re: CHANGES: Suggestion

On Thursday 27 November 2003 17.32, Ben Collins-Sussman wrote:
> s/are/is/
.
.
> s/messages/message/

Many people belives that to do stuff like the subtst. above is rude. I do
not! I'm very glad that you dare to do it. I'm getting better and better
that way :-)

>
> > * informal feedback are provided on the "post-update"
> > revision-bumping of
> > every file (#1556)
>
> Hm, this is tricky to describe. We're not giving any new feedback in
> updates, which is what your description sounds like. All we did was
> make 'svn up' print "Updated to revision N" *after* the
> directory-unlocking completed. So I'd write something like this:
>
> * don't show update-completion message until all wc work completes
> (#1556)

I was thinking me blind of this item (in fact using more time than I
should). Your suggestion are stolen shamelessy :-)

> My only other comment: please try to keep each bullet-point no more
> than one line long. It makes things easier to read. I can't tell if
> you followed this rule or not, because your mailer might have wrapped
> things.

It was a combination of not following the rule and wrapped lines.
From now, I follow the rules.

> Great job!

Thanks, I hope that I have managed to filter the commits right.

Jostein

-- 
Jostein Chr. Andersen <jostein@josander.net>
http://www.josander.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org