Re: PATCH: Errors that are ignored but should be cleared

Julian Foad <julianfoad@btopenworld.com> writes:

> I'm not clear on the intent of the existing comment. Should I
> delete the comment, or leave in place a comment saying "Remove the
> fs txn." if removing the txn is the intent of the call, or "(This
> removes the fs txn.)" if that is just a notable side-effect of the
> call?

I would not put a comment there. If you do add a comment then "Remove
the fs txn" is not useful as that's the documented behavior of
svn_repos_abort_report. A comment should tell me something special.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org