Re: [PATCH] svn_fs_text_changed

Chia-liang Kao <clkao@clkao.org> writes:

> > You are effectively changing this code only for 'diff' and 'merge',
> > though, so perhaps its a safe change to make.
>
> I thought we agreed on irc that this behavior is correct with the
> ignore_ancestry context?

And my words above don't contradict that. 'diff' and 'merge' should
be the only operations that use the ignore_ancestry stuff.

> > I'm still curious to see some real timings. I'd love to know what
> > would happen if you made this change for all uses of dir_delta().
>
> I just did some test and was surprised. svn diffing local svn tree
> branches which have almost all files modified but the same contents,
> and just a few files different, piping the output to /dev/null:
>
> With patch: average is 4 seconds; without patch: average is 6 seconds.
>
> Also tcsh's time tells me the average unshared data/stack space (%D) is
> about half (5M vs 10M).

Hey, that's good news. Now, revert your change, and do those same
tests after teaching your window_handler to notice no-op textdeltas.
Or, if you don't have time, I'd be willing to do this test comparison
myself -- just send me your recipe.

> But this is the case that my intention. I didn't do other tests to see
> if it degrades normal cases.

Well, yeah, those are the cases I had in mind. I rather figured you
weren't out to degrade your own use-case. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 25 17:44:08 2003