Re: [PATCH] svn_fs_text_changed

On Tue, 2003-11-25 at 23:34, C. Michael Pilato wrote:
> Ah, but this is slightly different. You're losing information here,
> namely the difference between "this file's contents haven't been
> changed" and "this file's contents have been changed, but happen to
> look just like those of another file". Is this difference
> significant? I really dunno.
> m<vYou are effectively changing this code only for 'diff' and 'merge',
> though, so perhaps its a safe change to make.

I thought we agreed on irc that this behavior is correct with the
ignore_ancestry context?

> I'm still curious to see some real timings. I'd love to know what
> would happen if you made this change for all uses of dir_delta().

I just did some test and was surprised. svn diffing local svn tree
branches which have almost all files modified but the same contents,
and just a few files different, piping the output to /dev/null:

With patch: average is 4 seconds; without patch: average is 6 seconds.

Also tcsh's time tells me the average unshared data/stack space (%D) is
about half (5M vs 10M).

But this is the case that my intention. I didn't do other tests to see
if it degrades normal cases.

Cheers,
CLK

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 25 17:23:14 2003