Re: [PATCH] Modified export behavior

John Szakmeister <john@szakmeister.net> writes:

> On Sunday 16 November 2003 12:57, Philip Martin wrote:
>>
>> I don't think the "if binary do this else do that" is necessary.
>> Binary files won't have keywords, eol-style and copy_and_translate
>> will just do a copy_file. Did you copy this pattern from elsewhere in
>> the code?
>
> Actually I did. I saw this pattern being used in svn_client_cat() in
> libsvn_client/cat.c. I had thought about removing it, but my impression was
> that it was some sort of safety precaution against someone specifying
> keywords on a binary file. If that's not the case, I'll chuck it.

We have client side code that prevents those keywords being set on
binary files. As far as I know, it doesn't prevent someone setting
the keywords on a non-binary file, and then changing the file to
binary. It's not clear to me whether we should ignore the keywords on
a binary file. If we do choose to ignore them I am a little uneasy
about the behaviour being distributed in lots of places in the code,
far better to pass some sort of "binaryness" indicator to
copy_and_translate.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org